Open
Conversation
SuragNuthulapaty
requested review from
NPIPHI,
mpkarpov-ui,
rkontham24 and
zyunlam
zyunlam
reviewed
Feb 1, 2025
|
|
||
|
|
||
|
|
||
| num = 0xf3626b6a |
Contributor
There was a problem hiding this comment.
this is the checksum, add a note or rename the variable to specify what that is
|
|
||
|
|
||
| num = 0xf3626b6a | ||
| buf = 0x00 |
|
|
||
| for col in cols_to_save: | ||
| # Writes a 4 byte float | ||
| if col is None: |
Contributor
There was a problem hiding this comment.
Add a comment to say that you noticed that most of the values with this parameter is a 4 byte float
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a method to take csv data and convert it to a launch file that can be streamed to MIDAS
To change what gets written, change the information in
discriminant_to_field_names. Each sensor discriminant should return an array of column names, None if the data does not matter, 1 if the data should be 1, or 0 if the data is a booleanTo use, run
python MIDAS/hilsim/data_converter.py <infile path> <outfile path>